Skip to content

Commit

Permalink
fix(a11y): icon button-black focus outline does not meet 3:1 contrast…
Browse files Browse the repository at this point in the history
… minimum in dark theme (#297)

## PR Checklist

Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] clarity.design website / infrastructure changes
- [ ] Other... Please describe:

## What is the current behavior?

<!-- Please describe the current behavior that you are modifying, or
link to a relevant issue. -->

Issue Number: [CDE-1604](https://jira.eng.vmware.com/browse/CDE-1604)

## What is the new behavior?
The focus outline colour defaults to the `webkit-focus-ring-color` in
dark theme on windows chrome.

## Does this PR introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

## Other information

Co-authored-by: Andrea Fernandes <[email protected]>
  • Loading branch information
andyfeds and Andrea Fernandes authored Mar 28, 2024
1 parent 62d7b9f commit ef26b12
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions projects/core/src/button-action/button-action.element.scss
Original file line number Diff line number Diff line change
Expand Up @@ -107,5 +107,6 @@ cds-icon,
@media (-webkit-min-device-pixel-ratio: 0) {
:host(:focus) .private-host::after {
outline-color: -webkit-focus-ring-color;
outline-style: auto;
}
}

0 comments on commit ef26b12

Please sign in to comment.