Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tabs): add actions section (#1620) (backport to 16.x) #1623

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

dtsanevmw
Copy link
Contributor

Backport of #1620

Copy link
Contributor

github-actions bot commented Nov 25, 2024

👋 @dtsanevmw,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

@dtsanevmw dtsanevmw self-assigned this Nov 25, 2024
Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

What kind of change does this PR introduce?

1: Slot which is being projected inside the header so basically
`<clr-tabs-actions>Whatever content you put here</clr-tabs-actions>`.
2: Directive `clrTabsAction` which you put on the element you want to be
interactable and part of the navigation of tabs ( arrows ).

<!-- Please check the one that applies to this PR using "x". -->

- [ ] Bugfix
- [X] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

<!-- Please describe the current behavior that you are modifying, or
link to a relevant issue. -->

Issue Number: CDE-2391

- [ ] Yes
- [X] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

---------

Co-authored-by: GitHub <[email protected]>
Copy link
Contributor

This PR introduces visual changes: d9d5295
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout dtsanevmw/cde-2391-16.x
git fetch https://github.com/vmware-clarity/ng-clarity.git d9d52956b5a27839e4ac936faa513fd5c3e530bf
git cherry-pick d9d52956b5a27839e4ac936faa513fd5c3e530bf
git push

Copy link
Contributor

@valentin-mladenov valentin-mladenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dtsanevmw dtsanevmw merged commit f7334b0 into 16.x Nov 25, 2024
9 checks passed
@dtsanevmw dtsanevmw deleted the dtsanevmw/cde-2391-16.x branch November 25, 2024 09:17
Copy link
Contributor

🎉 This PR is included in version 16.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants