Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a storage supported provider : HuaweiCloud OBS #8438

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

setoru
Copy link
Contributor

@setoru setoru commented Nov 21, 2024

Please add a summary of your change

Update docs to add HuaweiCloud OBS for HuaweiCloud Provider.

Please indicate you've done the following:

Copy link
Member

@kaovilai kaovilai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you working on this on a personal capacity? The repo referenced is on a personal account rather than as part of an organization.

@kaovilai
Copy link
Member

/kind changelog-not-required

@github-actions github-actions bot added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.11%. Comparing base (9f0026d) to head (871ba8d).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8438      +/-   ##
==========================================
+ Coverage   58.98%   59.11%   +0.12%     
==========================================
  Files         368      368              
  Lines       39000    39121     +121     
==========================================
+ Hits        23004    23125     +121     
- Misses      14532    14536       +4     
+ Partials     1464     1460       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@setoru
Copy link
Contributor Author

setoru commented Nov 25, 2024

Are you working on this on a personal capacity? The repo referenced is on a personal account rather than as part of an organization.

Yes, I am working on this in a personal capacity, and the referenced repo is indeed under my personal account.

@kaovilai
Copy link
Member

fixing changelog check

Copy link
Contributor

@reasonerjt reasonerjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@reasonerjt reasonerjt merged commit 3c06fc8 into vmware-tanzu:main Nov 27, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants