Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: config db seed by typeorm-extension #42

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

khuongln-1346
Copy link
Contributor

Pull Request types

  • 👾 Others

Description

Add database seeding by typeorm-extension

Checklist

  • 1. No more unconfirmed specs in the PR
  • 2. Tested the normal case and error cases following specs
  • 3. Is there a refactor to the old code? If yes, have you tested the old function and noted the impact yet?
  • 4. Loops have a set length and correct termination conditions
  • 5. There aren't any redundant or duplicate codes in PR (clean code)
  • 6. There aren't any hard-coded in the code in PR
  • 7. Optimization logic handling and optimizations SQL (for example, don't get redundant data or add an index to optimize performance, query only necessary fields...)
  • 8. Update issue status and add PR link to the issue

Evidence

(Screenshot or Video)

Discussion

@khuongln-1346 khuongln-1346 self-assigned this Nov 6, 2024
@khuongln-1346 khuongln-1346 merged commit 3684d1b into main Nov 6, 2024
2 checks passed
@khuongln-1346 khuongln-1346 deleted the feat.config-db-seed branch November 6, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant