Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove calls to get thumbnail post. #138

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jenkoian
Copy link

When using this plugin with
https://github.com/humanmade/network-media-library it doesn't work, it
seems this is because it attempts to retrieve the post of the thumbnail
(needlessly afaict) which won't work because the image exists on a
different site in the network.

Removing these calls seems to fix the issue and allows for a better
mutli site experience. I'm not sure of any adverse affects of this, but
let me know if you can see one.

When using this plugin with
https://github.com/humanmade/network-media-library it doesn't work, it
seems this is because it attempts to retrieve the post of the thumbnail
(needlessly afaict) which won't work because the image exists on a
different site in the network.

Removing these calls seems to fix the issue and allows for a better
mutli site experience. I'm not sure of any adverse affects of this, but
let me know if you can see one.
@jenkoian
Copy link
Author

Alternatively we could define hooks at the start and end of these functions so integrators can switch/restore blog.

@jenkoian
Copy link
Author

Here's an example of the hooks approach that I've just done for a similar issue on fieldmanager alleyinteractive/wordpress-fieldmanager#738 let me know if you'd prefer that route.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant