Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ostree: fix flatpak error (fixes #52273) #52276

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

SpidFightFR
Copy link
Contributor

@SpidFightFR SpidFightFR commented Sep 19, 2024

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, (x64-glibc)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • x64-musl

source of the patch: ostreedev/ostree#3307

Fixes #52273

Peace. ✌️

@chrysos349
Copy link
Contributor

fyi, the latest version is 2024.7

@SpidFightFR
Copy link
Contributor Author

fyi, the latest version is 2024.7

bloody hell... I didn't pay attention
thanks for that.

@SpidFightFR
Copy link
Contributor Author

fyi, the latest version is 2024.7

look i searched through it but the update seems to cause new issues.
The fix works for now, even with the current version.
Checks fail tho for some reasons, but it happens without my fixes as well, so i assume it's "normal"

@ahesford
Copy link
Member

Why does flatpak require a bump for this fix?

@SpidFightFR
Copy link
Contributor Author

SpidFightFR commented Sep 19, 2024

Why does flatpak require a bump for this fix?

I've seen people having issues with flatpak & libcurl when they don't rebuild it, just by precaution, i prefered to revbump flatpak.

@SpidFightFR
Copy link
Contributor Author

i can revert it if you want.

@ahesford
Copy link
Member

If flatpak might be flaky without a rebuild, we can keep the bump.

@SpidFightFR
Copy link
Contributor Author

If flatpak might be flaky without a rebuild, we can keep the bump.

i can't guarantee it's required but i really wouldn't trust the process of leaving it without a revbump.

@SpidFightFR
Copy link
Contributor Author

to be honest i'm more worried about the failing tests in the base repo, rather than by flatpak, atm.

@Duncaen Duncaen merged commit 31919fd into void-linux:master Sep 19, 2024
5 of 8 checks passed
@SpidFightFR SpidFightFR deleted the fix-ostree branch September 19, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flatpak displays an error since curl update
4 participants