Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put notebook name instead of Voila vuetify #25

Open
yarmenti opened this issue Dec 6, 2019 · 2 comments
Open

Put notebook name instead of Voila vuetify #25

yarmenti opened this issue Dec 6, 2019 · 2 comments

Comments

@yarmenti
Copy link

yarmenti commented Dec 6, 2019

Hi,

I wanted to modify the voila.tpl specifying the notebook name instead of "Voila vuetify".
However, when I'm looking at the resources that are passed to the template, the only location I could put it is the notebook metadata.

However, in resources.metadata, the only key/value pair set is: "name"/"Notebook".

I tried, using the UI editor to change the "name" attribute of my notebook metadata but it doesn't work.
Do you have any idea on how to do so?

Thank you,
@maartenbreddels
Copy link
Member

The original template does this:
https://github.com/voila-dashboards/voila/blob/8076df20102325827cca62f658c51bf9b5c99916/share/jupyter/voila/templates/default/nbconvert_templates/base.tpl#L9

Do you think the voila-vuetify template should also have this?

@yarmenti
Copy link
Author

yarmenti commented Dec 6, 2019 •
edited
Loading

Well, from my point of view, hard-coding the template (app.html) or the resources when opening voila with the current template is not relevant when dealing with the notebook name.
Thus, why not?

mariobuikhuizen added a commit that referenced this issue Dec 13, 2019
@mariobuikhuizen
Merge pull request #27 from yarmenti/add_nb_name_and_toolbar
bbc82a3 
Adding Notebook name to html title and in title-toolbar

relates to #25
mariobuikhuizen added a commit to mariobuikhuizen/voila that referenced this issue Dec 13, 2019
@mariobuikhuizen
fix: the default title in the template is always Notebook
8304018 
The property used as a fallback for the title of the template is
not initialized by Voila. Following nbconvert, in which this
property is set to the filename of the notebook [1], this commit
now does the same.

Related to: voila-dashboards/voila-vuetify#25

[1] https://github.com/jupyter/nbconvert/blob/6c6e5fa0c757169017fd325fad98efa8d4a368ea/nbconvert/exporters/exporter.py#L172
@mariobuikhuizen mariobuikhuizen mentioned this issue Dec 13, 2019
Merged
maartenbreddels pushed a commit to SylvainCorlay/voila that referenced this issue Feb 29, 2020
@mariobuikhuizen @maartenbreddels
fix: the default title in the template is always Notebook
1913453 
The property used as a fallback for the title of the template is
not initialized by Voila. Following nbconvert, in which this
property is set to the filename of the notebook [1], this commit
now does the same.

Related to: voila-dashboards/voila-vuetify#25

[1] https://github.com/jupyter/nbconvert/blob/6c6e5fa0c757169017fd325fad98efa8d4a368ea/nbconvert/exporters/exporter.py#L172
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maartenbreddels @yarmenti