fix: the default title in the template is always Notebook #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The property used as a fallback for the title of the template is not initialized by Voila. Following nbconvert, in which this property is set to the filename of the notebook [1], this commit now does the same. Related to: voila-dashboards/voila-vuetify#25 [1] https://github.com/jupyter/nbconvert/blob/6c6e5fa0c757169017fd325fad98efa8d4a368ea/nbconvert/exporters/exporter.py#L172
|
This means you can no longer override the name? |
|
If title is set in the notebook metadata, that is used.
|
|
I think we were setting it in resources, which this now clobbers |
|
This breaks our tests, I'll fix that after the weekend. |
|
Yeah so extra resources should take precedence still https://github.com/voila-dashboards/voila/blob/master/voila/handler.py#L70 So this is backwards compatible |
maartenbreddels
force-pushed
the
fix_template_title
branch
from
eae52f7 to
3cefe67
Compare
maartenbreddels
approved these changes
Dec 18, 2019
|
This looks good. @maartenbreddels did you want to take another look? or can this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The property used as a fallback for the title of the template is
not initialized by Voila. Following nbconvert, in which this
property is set to the filename of the notebook [1], this commit
now does the same.
Related to: voila-dashboards/voila-vuetify#25
[1] https://github.com/jupyter/nbconvert/blob/6c6e5fa0c757169017fd325fad98efa8d4a368ea/nbconvert/exporters/exporter.py#L172