Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev to merge, add Favourite Candidate page and modify Favourite District Page #127

Merged
merged 7 commits into from
Nov 20, 2019

Conversation

dasaitamago
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • [ Yes] Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • [ Yes] i18n translation has been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    feature added
    add Favourite Candidate page

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?
    add Favourite Candidate page

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

@cswbrian
Copy link
Collaborator

@dasaitamago

./src/App.js
Module not found: Can't resolve 'components/pages/fav-candidate' in '/Users/brianyfleung/Documents/open-data/district-councils-dashboard/web/src'

@dasaitamago
Copy link
Contributor Author

sorry, the files are added.

@cswbrian cswbrian merged commit 5a0f9e9 into vote4hk:dev Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants