Fix bug where empty string is a valid focusKey

vovacodes · Sep 2, 2021 · a1cb76e · a1cb76e
1 parent 12255c9
commit a1cb76e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/packages/demo/src/apps/SettingsMenu/Slider.tsx b/packages/demo/src/apps/SettingsMenu/Slider.tsx
@@ -1,7 +1,7 @@
 import * as React from "react"
 import { useState } from "react"
 import { motion } from "framer-motion"
-import { Direction, Focusable, SyntheticGamepadKeyEvent } from "react-sunbeam"
+import { Direction, Focusable } from "react-sunbeam"
 import { Colors, Typography } from "../../styles.js"
 import { isCancel, isLeft, isRight, isSelect } from "../../keyPressUtils.js"
 

diff --git a/packages/react-sunbeam/package.json b/packages/react-sunbeam/package.json
@@ -1,6 +1,6 @@
 {
     "name": "react-sunbeam",
-    "version": "2.0.0-beta.2",
+    "version": "2.0.0-beta.3",
     "description": "Spatial navigation and focus management for React",
     "keywords": [
         "spatial-navigation",

diff --git a/packages/react-sunbeam/src/focus/FocusableNode.ts b/packages/react-sunbeam/src/focus/FocusableNode.ts
@@ -31,7 +31,7 @@ export class FocusableNode implements IFocusableNode {
         customGetPreferredChild?: CustomGetPreferredChildFn
         lock: Direction[] | Direction | undefined
     }) {
-        focusKey = focusKey ?? `focusable:${randomId()}`
+        focusKey = focusKey || `focusable:${randomId()}`
         this.focusKey = focusKey
         this.path = [...parentPath, focusKey]
         this.getBoundingBox = getBoundingBox