-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Adding config setting to disable singleton cache #3956
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3956 +/- ##
========================================
Coverage 15.85% 15.85%
========================================
Files 731 731
Lines 81886 81886
Branches 1093 1093
========================================
Hits 12987 12987
Misses 68899 68899
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
9ad6b78
to
55a3cbd
Compare
Important Review skippedIgnore keyword(s) in the title. Ignored keywords (3)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Example usage
TODO
When singleton caching is disabled, there are a variety of places where patterns like this are used where the
reload()
is now always unnecessary:We should probably refactor those calls into a single method call so that unnecessary reloads can be skipped: