Change to using normal imports #112
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brimoor
requested changes
Jan 23, 2024
| from links.query_intent_classifier import classify_query_intent | ||
| from links.docs_query_dispatcher import run_docs_query, stream_docs_query | ||
| from links.computer_vision_query_dispatcher import ( | ||
| from voxelgpt.links.query_moderator import moderate_query |
There was a problem hiding this comment.
Unfortunately we can't use this import style here because the voxelgpt.py module is also intended for direct usage via Python, in which case the code is not running as a package.
That said, the changes in this module aren't actually required right? Relative imports should be fine.
| import fiftyone.operators as foo | ||
| import fiftyone.operators.types as types | ||
|
|
||
|
|
||
| from .voxelgpt import ask_voxelgpt_generator | ||
| import db |
There was a problem hiding this comment.
Isn't the idea of voxel51/fiftyone#4029 that users should adopt this style?
from voxelgpt.voxelgpt import ask_voxelgpt_generator
from voxelgpt import dbwhere the name of their source folder is treated as the package name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dependent on voxel51/fiftyone#4029