fix: update-bls-cmdline is not supported on Amazon Linux 2023 #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
requested changes
Aug 20, 2024
There was a problem hiding this comment.
I would simplify the whole method to:
def self.mkconfig_cmdline
os = Facter.value(:os)
needs_bls_cmdline = os.is_a?(Hash) && os['family'] == 'RedHat' && !['Amazon', 'Fedora'].include?(os['name']) && \
os['release']['major'].to_i == 9 && os['release']['minor'].to_i >= 3
cmdline = [mkconfig_path]
cmdline << '--update-bls-cmdline' if needs_bls_cmdline
cmdline
endAnd then perhaps the Amazon and Fedora exceptions aren't needed since they don't have version 9 that we need to care about.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR fixes incompatibility with Amazon Linux 2023, which doesn't support grub2 update-bls-cmdline