-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 5.1.2 #105
Release 5.1.2 #105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The -rc0
needs to be removed from the version in metadata.json
for the changelog to be generated correctly.
I wonder why that simp-2.3.1
tag appeared. Maybe should be deleted?
Hmm, I used documentation https://voxpupuli.org/docs/releasing_version/
I assumed that will be removed during actual release, I will remove the suffix |
e3969cc
to
3f4f5e1
Compare
I don't see that tag? $ git tag |
3f4f5e1
to
968fbfa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That tag is here: https://github.com/voxpupuli/puppet-augeasproviders_grub/releases/tag/simp-2.3.1
🤷
I think you need to regenerate the changelog now that you've set the version. It shouldn't say Unreleased
, it should be v5.1.2
. Here's an example: voxpupuli/puppet-python#697
968fbfa
to
c6fa031
Compare
I just committed my section of the change and removed others manually |
I deleted that simp-2.3.1 tag from the repo so that hopefully it doesn't show up in the next changelog. |
Release 5.1.2