modulesync 9.1.0 #85
Merged
modulesync 9.1.0 #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenyon
force-pushed
the
modulesync
branch
2 times, most recently
from
af20281 to
3041829
Compare
|
The acceptance tests aren't going to work in docker containers, since the test code is setting kernel boot parameters. We'll need to run these tests on full virtual machines. |
tuxmea
approved these changes
Oct 15, 2023
bastelfreak
force-pushed
the
modulesync
branch
from
4144762 to
cfdfe3c
Compare
|
In that case: should we merge none the less and permanently brick the CI (seems very bad)? I dont think we will get full virtual machines for all our testcases anytime soon. Maybe we can rig something up in our modulesync config where we can explicitly disable the test cases we pull from the metadata? |
|
@zilchms there is some support recently for running acceptance tests using vagrant-libvirt virtual machines: voxpupuli/gha-puppet#49 |
zilchms
force-pushed
the
modulesync
branch
2 times, most recently
from
bde2426 to
0ce2607
Compare
Testing grub isn't reliable on Docker.
silug
approved these changes
Jul 9, 2024
silug
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.