Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support EL9 #99

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Support EL9 #99

merged 1 commit into from
Dec 9, 2024

Conversation

treydock
Copy link
Contributor

@treydock treydock commented Dec 8, 2024

Replaces #84

@treydock treydock requested a review from bastelfreak December 8, 2024 15:28
package { 'systemd-udev':
ensure => 'installed',
}
Package['systemd-udev'] -> Sysctl <| |>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this would also work

file { '/etc/sysctl.d':
  ensure => directory,
}

And in particular if there's some autorequire that sets up the dependency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would work though for the augeas resource I don't think autorequire would be involved.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we document this dependency in the README.md?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in the real world, this is not an issue as RHEL ships even minimal RHEL9 with systemd-udev. I think this is only an issue on minimal containers and sysctl isn't useful for containers usually since the kernel runs on the host.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, you don't hit it if you manage /etc/sysctl.conf because it's safe to assume /etc exists.

@ekohl ekohl added the enhancement New feature or request label Dec 8, 2024
@ekohl ekohl merged commit 176417e into voxpupuli:master Dec 9, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants