Add FreeBSD platform

[olevole]

Pull request acceptance prerequisites:

• Signed the CLA (if not already signed)
• Rebased/up-to-date with base branch
• Tests pass
• Updated CHANGELOG.md with patch notes (if necessary)
• Updated CONTRIBUTORS (if attribution is requested)

[tylerjl]

Thanks for the contribution @olevole!

Although I don't have the acceptance test infrastructure to run against *BSD, I'm fine merging changes on a best-effort basis by the community so people can get support for more exotic operating systems. This means they won't get as intensely tested as the Linux distributions, but support will be there.

A few things:

• The CLA still needs to be signed (it checks against the email address you used to commit)
• Some basic unit tests would be good to add somewhere like here so there's some degree of testing.
• the metadata.json should be updated to reflect FreeBSD support

Again, thank you for all the work, this will be a great addition!

[fatmcgav]

Hi there,

Firstly, thank you for taking the time to contribute, and apologies for the radio silence from Elastic on this PR.

I'm going to be working on this module over the next few weeks, with an ultimate aim of updating the module to support the elasticsearch 7.x and simplifying the module to make it easier to use.

I'll be reviewing all the open issues and PRs over the next few days, and will merge or provide feedback where appropriate.

So please hang in there whilst we give this module some TLC.

Thanks again.

[elasticmachine]

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

[smortex]

It makes sense!

@olevole this has been lagging for a tremendous amount of time, and the module was recently adopted by voxpupuli and gained a refresh! Would you be interested to apply these changes on top of the current master branch?

I think you could also add FreeBSD in metadata.json 😉

[olevole]

It makes sense!

@olevole this has been lagging for a tremendous amount of time, and the module was recently adopted by voxpupuli and gained a refresh! Would you be interested to apply these changes on top of the current master branch?

I think you could also add FreeBSD in metadata.json wink

Absolutely and always interested in FreeBSD ;-) Unfortunately, I still can not find the time for unit tests.

[smortex]

Absolutely and always interested in FreeBSD ;-) Unfortunately, I still can not find the time for unit tests.

🎉

I do not think we need to worry about tests at this point. Maybe one day we will be able to run acceptance tests on FreeBSD but at the moment the unit tests are probably fine.

Due to the massive update to have the code working with recent puppet / ruby, rebasing is likely to be a pain. Maybe an easier strategy is to git a fresh 'master', apply the changes there (probably with some adjustments) and push the changes to update this PR:

git fetch origin               # Get the latest code from GitHub
git reset --hard origin/master # Loose all changes and put the branch on master
# re-apply the changes
git add .  && git commit
git push -f                    # -f needed: we re-wrote history

[vox-pupuli-tasks]

Dear @olevole, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks