Better volume options handling #220
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glorpen
force-pushed
the
fix-remove-options
branch
from
226025b to
1809c4e
Compare
Merged
glorpen
force-pushed
the
fix-remove-options
branch
2 times, most recently
from
d6c6f9e to
a8d80a2
Compare
glorpen
force-pushed
the
fix-remove-options
branch
from
a8d80a2 to
56d773e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Fixes volume
remove_optionsoption as currently it will create duplicated resources (code wants to remove and add one at the same time) and converts internal options handling to use hash instead arrays/yamls.Currently code is based on #219 to not make rebases specially for indentation.
This Pull Request (PR) fixes the following issues
n/a