Remove deprecated validate_*
#66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the same as voxpupuli#65 but now using datatypes instead of the validate_legacy function.
The has_key function is deprecated, using an internal Puppet function instead.
smortex
reviewed
Dec 13, 2023
| $download_url = undef, | ||
| $install_dir = $winlogbeat::params::install_dir, | ||
| $tmp_dir = $winlogbeat::params::tmp_dir, | ||
| Optional[String] $major_version = undef, |
There was a problem hiding this comment.
An empty string is probably not acceptable?
Suggested change
| Optional[String] $major_version = undef, | |
| Optional[String[1]] $major_version = undef, |
As a rule of thumb, String without a minimum length is a smell, and if '' is a valid value, prefer String[0] to make it explicit that an empty string is okay.
I will not report this for other occurrences in this file.
Comment on lines
+31
to
+32
| String $package_ensure = $winlogbeat::params::package_ensure, | ||
| String $service_ensure = $winlogbeat::params::service_ensure, |
There was a problem hiding this comment.
Stdlib has some helpers:
Suggested change
| String $package_ensure = $winlogbeat::params::package_ensure, | |
| String $service_ensure = $winlogbeat::params::service_ensure, | |
| Stdlib::Ensure::Package $package_ensure = $winlogbeat::params::package_ensure, | |
| Stdlib::Ensure::Service $service_ensure = $winlogbeat::params::service_ensure, |
| String $service_ensure = $winlogbeat::params::service_ensure, | ||
| Boolean $service_enable = $winlogbeat::params::service_enable, | ||
| Optional[String] $service_provider = $winlogbeat::params::service_provider, | ||
| String $registry_file = $winlogbeat::params::registry_file, |
There was a problem hiding this comment.
Is a Stdlib::Windowspath more suitable?
Comment on lines
+43
to
+44
| String $install_dir = $winlogbeat::params::install_dir, | ||
| String $tmp_dir = $winlogbeat::params::tmp_dir, |
There was a problem hiding this comment.
Is a Stdlib::Windowspath more suitable?
| $metrics = undef, | ||
| Boolean $use_generic_template = $winlogbeat::params::use_generic_template, | ||
| Stdlib::Fqdn $beat_name = $winlogbeat::params::beat_name, | ||
| Array $tags = $winlogbeat::params::tags, |
There was a problem hiding this comment.
It's always good if we can qualify this more precisely, e.g. Array[String[1]] for an array of non-emty strings.
Co-authored-by: Romain Tartière <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same as #65 but now
using datatypes instead of the
validate_legacy function.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues