Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serum2 #46

Merged
merged 60 commits into from
Jul 2, 2024
Merged

Serum2 #46

merged 60 commits into from
Jul 2, 2024

Conversation

mkalkbrenner
Copy link
Collaborator

No description provided.

@mkalkbrenner mkalkbrenner marked this pull request as draft May 14, 2024 10:35
@mkalkbrenner
Copy link
Collaborator Author

The included tests run on ZeDMD and Pixelcade. But using libpinmame with Serum V1 crashes. So some more debugging is required...

@jsm174
Copy link
Collaborator

jsm174 commented May 14, 2024

I think mac runners might be arm64 now, which is why the test might have failed. Have to research...

@jsm174
Copy link
Collaborator

jsm174 commented May 14, 2024

we could probably use uname -m to detect

@francisdb
Copy link
Contributor

See actions/runner-images#9741 (comment)
from macos-14 on there are no standard x64 versions any more. So best to stick to macos-13 for the x64 build.

@jsm174
Copy link
Collaborator

jsm174 commented May 14, 2024

No, we can keep these both on macos-latest. Building is not an issue.

@jsm174 jsm174 marked this pull request as ready for review July 2, 2024 15:28
@jsm174 jsm174 merged commit 0eb2052 into vpinball:master Jul 2, 2024
11 checks passed
@jsm174
Copy link
Collaborator

jsm174 commented Jul 2, 2024

@mkalkbrenner - truly amazing work!!

@PastorL69
Copy link

PastorL69 commented Jul 11, 2024

@mkalkbrenner , take a break .. 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants