Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AV-2034: Fix header search breaking on consecutive searches #2037

Merged
merged 9 commits into from
Sep 25, 2023

Conversation

bzar
Copy link
Contributor

@bzar bzar commented Aug 22, 2023

  • Fix path.current containing invalid characters
  • Set search form action URL explicitly to remove accumulating garbage
  • Improve string handling in form submit
  • Removed ckanext-datarequests

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage: 16.66% and no project coverage change.

Comparison is base (910217c) 23.42% compared to head (4c854e5) 23.42%.
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2037   +/-   ##
=======================================
  Coverage   23.42%   23.42%           
=======================================
  Files          43       43           
  Lines        6031     6031           
  Branches       34       34           
=======================================
  Hits         1413     1413           
  Misses       4618     4618           
Flag Coverage Δ
cdk 93.10% <ø> (ø)
ckan 18.01% <16.66%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cdk/lib/ckan-stack.ts 91.06% <ø> (ø)
ckan/ckanext/ckanext-ytp_main/ckanext/ytp/cli.py 23.21% <0.00%> (ø)
ckan/ckanext/ckanext-ytp_main/ckanext/ytp/dcat.py 8.83% <0.00%> (ø)
...kan/ckanext/ckanext-ytp_main/ckanext/ytp/plugin.py 37.10% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bzar bzar merged commit c5e8ee3 into master Sep 25, 2023
22 of 24 checks passed
@bzar bzar deleted the AV-2034_header-search-fix branch September 25, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants