Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AV-2079: Fix resourcestatus causing an error #2096

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

Zharktas
Copy link
Contributor

resourcestatus expects an empty value for it use sessions fetching tags from aws. When driver_options is not defined, environ will input string "None" into it.

@Zharktas Zharktas force-pushed the AV-2079_fix_resource_status_error branch from bf8f941 to 6761069 Compare October 23, 2023 07:18
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e637813) 23.45% compared to head (6761069) 23.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2096      +/-   ##
==========================================
+ Coverage   23.45%   23.46%   +0.01%     
==========================================
  Files          43       43              
  Lines        6029     6030       +1     
  Branches       34       34              
==========================================
+ Hits         1414     1415       +1     
  Misses       4615     4615              
Flag Coverage Δ
cdk 93.13% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cdk/lib/ckan-stack.ts 91.16% <100.00%> (+0.04%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Zharktas Zharktas merged commit e01029f into master Oct 23, 2023
19 of 20 checks passed
@Zharktas Zharktas deleted the AV-2079_fix_resource_status_error branch October 23, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants