Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AV-2079: Fix cloudstorage to handle empty strings in config #2097

Merged

Conversation

Zharktas
Copy link
Contributor

literal_eval doesn't cope with empty string, lets be coherent with our config.

@Zharktas Zharktas force-pushed the AV-2079_fix_cloudstorage_to_handle_empty_strings_in_config branch from 1cc5213 to bbc073a Compare October 23, 2023 09:48
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6761069) 23.46% compared to head (bbc073a) 23.43%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2097      +/-   ##
==========================================
- Coverage   23.46%   23.43%   -0.04%     
==========================================
  Files          43       43              
  Lines        6030     6038       +8     
  Branches       34       34              
==========================================
  Hits         1415     1415              
- Misses       4615     4623       +8     
Flag Coverage Δ
cdk 93.13% <ø> (ø)
ckan 17.99% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Zharktas Zharktas merged commit a0bed99 into master Oct 23, 2023
22 of 24 checks passed
@Zharktas Zharktas deleted the AV-2079_fix_cloudstorage_to_handle_empty_strings_in_config branch October 23, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants