Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AV-2082: Better CKAN UWSGI configuration #2100

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

bzar
Copy link
Contributor

@bzar bzar commented Oct 24, 2023

  • Converted ckan-uwsgi.ini into a template rendered in CKAN init script
  • Make process/thread count configurable using .env in docker and parameter store in cdk
  • New uwsgi settings:
    • strict: Error on invalid configuration
    • max-worker-lifetime/worker-reload-mercy: periodically reload workers to avoid getting stuck
    • single-interpreter: we only run one app in uwsgi so we can use this as a small optimization
    • die-on-term: if uwsgi gets SIGTERM, actually stop instead of just reloading (can avoid issues where a container is stuck)
    • thunder-lock: more balanced connection accepting with threads

@bzar bzar marked this pull request as ready for review October 24, 2023 07:03
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5a8c75b) 23.43% compared to head (63757bf) 23.43%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2100   +/-   ##
=======================================
  Coverage   23.43%   23.43%           
=======================================
  Files          43       43           
  Lines        6038     6038           
  Branches       34       34           
=======================================
  Hits         1415     1415           
  Misses       4623     4623           
Flag Coverage Δ
cdk 93.13% <ø> (ø)
ckan 17.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cdk/lib/ckan-stack.ts 91.16% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bzar bzar merged commit 345bee0 into master Oct 24, 2023
24 checks passed
@bzar bzar deleted the AV-2082_parametrize-uwsgi-processes-threads branch October 24, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants