Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AV-689: Convert guide tables to bootstrap responsive ones #2136

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

bzar
Copy link
Contributor

@bzar bzar commented Dec 5, 2023

  • Copy common scripts to avoindata theme in gulp
  • Configure responsive table inject script for avoindata-theme
  • Attach responsive table inject script to guide pages
  • Update responsive table inject script to match current DOM structure
  • Fix issue in responsive table inject script that would cause duplicate wrapper elements

Copy link

cypress bot commented Dec 5, 2023

Passing run #4580 ↗︎

0 85 3 0 Flakiness 0

Details:

Merge fd1ab31 into 46e2b73...
Project: opendata Commit: fb3c608404 ℹ️
Status: Passed Duration: 05:15 💡
Started: Dec 7, 2023 7:37 AM Ended: Dec 7, 2023 7:43 AM

Review all test suite changes for PR #2136 ↗︎

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (46e2b73) 23.43% compared to head (fd1ab31) 23.43%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2136   +/-   ##
=======================================
  Coverage   23.43%   23.43%           
=======================================
  Files          43       43           
  Lines        6038     6038           
  Branches       34       34           
=======================================
  Hits         1415     1415           
  Misses       4623     4623           
Flag Coverage Δ
cdk 93.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Zharktas Zharktas changed the title AV-689: Convert guide tables to bootstrap responsive oens AV-689: Convert guide tables to bootstrap responsive ones Dec 13, 2023
@bzar bzar merged commit a732b9f into master Dec 14, 2023
41 checks passed
@bzar bzar deleted the AV-689_guide-mobile-style branch December 14, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants