Skip to content
This repository has been archived by the owner on Feb 18, 2021. It is now read-only.

Portability fixes for custom Kubernetes clusters #47

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ugoviti
Copy link

@ugoviti ugoviti commented Aug 20, 2020

Hi,

thank you for your chart Romero!

If you like, I added a little feature allowing customizations about kube dns default domain "cluster.local"
And added the ability to disable activemq replicas when not needed for small deploy.

Follow Changelog:

  • Support other cluster domains than "cluster.local" via "kubernetesDNSDomain" key
  • Selective enable of slaves and replicas
  • apiVersion: v1 fix into Chart.yaml for Helm 3 (already exist other pull request for that)

…Domain" key

Selective enable of slaves and replicas
apiVersion: v1 fix into Chart.yaml for Helm 3
@vromero
Copy link
Owner

vromero commented Aug 28, 2020

Thanks @ugoviti.

I intentionally removed the support for multiple slaves in the past. This is due to the fact that all artemis clustering is doing is to have its own (worse) kubernetes orchestration to then only have master-slave pairs within it.

This is the root reason why I have a cold feet about this chart. I'd like to discuss it with all interested parties feel free to chime in #50.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants