contract data availability proofs & updated types & bug fixes #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This informs the all event listeners of "new-epoch" that a new epoch has started and includes the hive block number, epoch number, net id, and the new witness set
vaultec81
reviewed
Apr 2, 2024
src/services/new/fileUploadManger.ts
Outdated
| type: 'proof' | ||
| data: string | ||
| signature: { sig: string; bv: string } | ||
| epochDefinitionHiveBlock: number // just some metadata for the client to aid verification |
There was a problem hiding this comment.
Simplify to epochHeight or just epoch is the convention I'm going for.
src/services/new/fileUploadManger.ts
Outdated
Comment on lines
281
to
286
| { | ||
| type: 'data-availablity', | ||
| cid: respInfo.cid, | ||
| }, | ||
| { onlyHash: true }, | ||
| ) |
There was a problem hiding this comment.
Why not sign the CID directly instead of adding this? Assuming it's the only thing we need to verify at the moment.
There was a problem hiding this comment.
Signing CID bytes doesn't indicate the intent of the signature. It could be a number of things. This way makes it clear this is for the data availability proof.
vaultec81
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when merging please rebase instead of merging. the merge commit messes up the git history on my fork
see commit messages for detailed changes