Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fs update #33

Merged
merged 2 commits into from
Jul 7, 2022
Merged

Fs update #33

merged 2 commits into from
Jul 7, 2022

Conversation

Lewih
Copy link
Collaborator

@Lewih Lewih commented Jun 25, 2022

Removed scratch folder test from the Shared FS test file because is site specific.

Added check for /apps/VSCsite folders because site agnostic.

Works on all the sites.

Some tests fail in Hortense and Hydra, check required by site admins. (look like a bad mount)

@Lewih Lewih linked an issue Jun 25, 2022 that may be closed by this pull request
@Lewih
Copy link
Collaborator Author

Lewih commented Jun 27, 2022

Screenshot 2022-06-27 at 16 15 40
Current fail situation on the sites (excluding genius)

ready for merge

@Lewih
Copy link
Collaborator Author

Lewih commented Jul 7, 2022

All tests passing on genius

Copy link
Collaborator

@RVerschoren RVerschoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RVerschoren RVerschoren merged commit 4b0c442 into vscentrum:main Jul 7, 2022
@Lewih Lewih deleted the fs-update branch July 13, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FS test problems
2 participants