Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add composition for MariaDB service #263

Merged
merged 3 commits into from
Dec 5, 2023
Merged

Add composition for MariaDB service #263

merged 3 commits into from
Dec 5, 2023

Conversation

TheBigLee
Copy link
Member

@TheBigLee TheBigLee commented Nov 21, 2023 •
edited
Loading

Checklist

  • The PR has a meaningful title. It will be used to auto generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

@TheBigLee TheBigLee force-pushed the feature/mariadb branch 23 times, most recently from bc468a4 to 2c8eaea Compare November 29, 2023 15:12
@TheBigLee TheBigLee changed the title Feature/mariadb Add composition for MariaDB service Nov 29, 2023
@TheBigLee TheBigLee added the enhancement New feature or request label Nov 29, 2023
@TheBigLee TheBigLee marked this pull request as ready for review November 29, 2023 15:15
@TheBigLee TheBigLee force-pushed the feature/mariadb branch 2 times, most recently from 9359841 to 35b5e73 Compare November 29, 2023 16:29
@TheBigLee TheBigLee force-pushed the feature/mariadb branch 13 times, most recently from d3a107f to d2fc989 Compare November 30, 2023 15:16
@TheBigLee
Copy link
Member Author

This PR adds much more than what is in the title, I would have split it in 2 PRs. It's not clear which code is for E2E and which is just the composition and everything related to that.

I removed the e2e tests from this PR and added them to a separate PR: #267

@TheBigLee TheBigLee force-pushed the feature/mariadb branch 2 times, most recently from 8dfb658 to d5e529a Compare November 30, 2023 15:32
Kidswiss
Kidswiss requested changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@Kidswiss Kidswiss left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have another look at how we should enable the stsResizer.

component/component/vshn_appcat_services.jsonnet Outdated Show resolved Hide resolved
component/component/statefuleset-resize-controller.jsonnet Outdated Show resolved Hide resolved
@TheBigLee TheBigLee force-pushed the feature/mariadb branch 2 times, most recently from 599fda3 to 4a9efd9 Compare December 4, 2023 13:04
@TheBigLee
Add composition for MariaDB service
0f998af 
Signed-off-by: Nicolas Bigler <[email protected]>
@TheBigLee
Refactor sts-resizer
96f77e4 
Signed-off-by: Nicolas Bigler <[email protected]>
@TheBigLee
Refactor docs
4416f34 
Signed-off-by: Nicolas Bigler <[email protected]>
@TheBigLee TheBigLee merged commit b29426c into master Dec 5, 2023
22 checks passed
@TheBigLee TheBigLee deleted the feature/mariadb branch December 5, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kidswiss Kidswiss Kidswiss approved these changes

@zugao zugao Awaiting requested review from zugao

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheBigLee @Kidswiss @zugao