-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix jq version for github actions #334
Conversation
1c69467
to
1df1520
Compare
3b4e44f
to
d3db2d9
Compare
component/component/app.jsonnet
Outdated
], | ||
kind: 'Secret', | ||
name: 'github-ci-secret', | ||
namespace: 'schedar-e2e', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would keep the project name instead of team name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't - it's descriptive for all engineers right now, it's also easy way to contact with us.
Component can be owned by different teams, schedar
is just one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's currently deployed as schedar-e2e
, this adjustment makes that the jsonnet actually matches what's deployed.
But if you like the old name more, I can change it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't - it's descriptive for all engineers right now, it's also easy way to contact with us. Component can be owned by different teams,
schedar
is just one
True, but schedar owns appcat, so it should be the same either way.
But thinking a bit more about the naming, it might make sense to go with appcat-e2e
. Otherwise, we're leaking some vshn internal naming to the product.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, I saw it worked for LAB cluster, I don't care that much about namespace name, LGTM
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug
,enhancement
,documentation
,change
,breaking
,dependency
as they show up in the changelog.