Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR for appcat on pdb-bug #551

Merged
merged 2 commits into from
Nov 25, 2024
Merged

PR for appcat on pdb-bug #551

merged 2 commits into from
Nov 25, 2024

Conversation

vshnbot
Copy link
Collaborator

@vshnbot vshnbot commented Nov 25, 2024

Summary

  • Currently whenever the pg instnace is being rescaled the PDB cannot be deleted by crossplane as it is protected by deletion protection.

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog

Link: vshn/appcat#271

@zugao zugao added bug Something isn't working patch labels Nov 25, 2024
zugao
zugao approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zugao zugao removed the bug Something isn't working label Nov 25, 2024
@zugao zugao merged commit e864a71 into master Nov 25, 2024
10 checks passed
@zugao zugao deleted the appcat/271/pdb-bug branch November 25, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zugao zugao zugao approved these changes

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vshnbot @zugao