Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix certdir being dropped #110

Merged
merged 3 commits into from
May 30, 2024
Merged

Fix certdir being dropped #110

merged 3 commits into from
May 30, 2024

Conversation

Kidswiss
Copy link
Contributor

@Kidswiss Kidswiss commented May 30, 2024 •
edited
Loading

Correctly pass the certdir to the manager.

Checklist

  • The PR has a meaningful title. It will be used to auto generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • I have run successfully make test-e2e locally.
  • Update the documentation.
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

@Kidswiss Kidswiss added the bug Something isn't working label May 30, 2024
@Kidswiss Kidswiss requested a review from zugao May 30, 2024 09:41
zugao
zugao approved these changes May 30, 2024
View reviewed changes
Copy link
Collaborator

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zugao zugao merged commit 04d89cd into master May 30, 2024
3 checks passed
@zugao zugao deleted the fix-tls branch May 30, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zugao zugao zugao approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kidswiss @zugao