Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: closePickupPointsModal receives props #208

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

lpolon
Copy link
Contributor

@lpolon lpolon commented Sep 6, 2023

to validate address and check active pickup point in related reducers

What is the purpose of this pull request?

pass props required to fixes in Shipping-manager to address-form-reducer
related PR:
https://github.com/vtex/shipping-manager/pull/119

What problem is this solving?

How should this be manually tested?

Screenshots or example usage

related PR:
https://github.com/vtex/shipping-manager/pull/119

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

…and check active pickup point in related reducers
@lpolon lpolon requested a review from a team as a code owner September 6, 2023 21:00
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Sep 6, 2023

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

jeffersontuc
jeffersontuc previously approved these changes Sep 11, 2023
@lpolon lpolon merged commit 38d034f into main Sep 11, 2023
13 checks passed
@lpolon lpolon deleted the fix/valid-address-on-modal-close branch September 11, 2023 14:13
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Sep 11, 2023

Your PR has been merged! App is being published. 🚀
Version 3.8.0 → 3.8.1

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants