Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/add root path #209

Merged
merged 3 commits into from
Sep 29, 2023
Merged

Fix/add root path #209

merged 3 commits into from
Sep 29, 2023

Conversation

mateussaggin
Copy link
Contributor

What is the purpose of this pull request?

  • Fix API requests not using rootPath.

What problem is this solving?

  • API errors when store has rootPath configuration.

How should this be manually tested?

To test on the final domain user https://www.angeloni.com.br/super/checkout?workspace=chkv1

Screenshots or example usage

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@mateussaggin mateussaggin requested a review from a team as a code owner September 29, 2023 19:18
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Sep 29, 2023

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

Copy link

@vhaalmeida vhaalmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mateussaggin mateussaggin merged commit 628adbc into main Sep 29, 2023
51 checks passed
@mateussaggin mateussaggin deleted the fix/add-root-path branch September 29, 2023 19:36
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Sep 29, 2023

Your PR has been merged! App is being published. 🚀
Version 3.8.1 → 3.8.2

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants