Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add stop() for @beforeOpen and beforeClose event #367 #402

Merged
merged 14 commits into from
Dec 7, 2023
Merged

feat: add stop() for @beforeOpen and beforeClose event #367 #402

merged 14 commits into from
Dec 7, 2023

Conversation

hunterliu1003
Copy link
Member

fixes #367

@hunterliu1003 hunterliu1003 self-assigned this Nov 14, 2023
@Mini-ghost
Copy link
Collaborator

LGTM

Currently, the purpose of modelValueLocal is to synchronize _modelValueLocal and check whether the user prevents the modal from opening or closing. Therefore, I use getters and setters instead of computed to achieve a slight performance improvement.

@hunterliu1003 hunterliu1003 added the v4.5 v4.5 label Nov 29, 2023
@hunterliu1003 hunterliu1003 changed the base branch from master to feat/4.5 November 30, 2023 03:42
@hunterliu1003 hunterliu1003 merged commit dd595ed into feat/4.5 Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mini-ghost Mini-ghost Mini-ghost approved these changes

Assignees

@hunterliu1003 hunterliu1003

Labels
v4.5 v4.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How am I supposed to prevent a modal from being closed?
2 participants
@hunterliu1003 @Mini-ghost