Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: placeholder image height on the collections page #186

Conversation

ymaheshwari1
Copy link

@ymaheshwari1 ymaheshwari1 commented Mar 13, 2022

Description

Added height for the placeholder component

Related Issue

closes #181

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Baroshem
Copy link
Contributor

Hey @ymaheshwari1

Sorry for keep you waiting. I was bit busy with other tasks.

I dont think that this will solve the issue becuase the bug was reported as an issue in the javascript, not the styles.

@ymaheshwari1
Copy link
Author

Hey @ymaheshwari1

Sorry for keep you waiting. I was bit busy with other tasks.

I dont think that this will solve the issue becuase the bug was reported as an issue in the javascript, not the styles.

Hi @Baroshem
Actually the placeholder image gets loaded always but the issue is that the height of the image is so small that's it is not properly visible.

@Baroshem
Copy link
Contributor

@ymaheshwari1

But the problem is that we expect that the product will contain image, while in some cases you may not have an image. So in here, an optional chaining should be added in order to avoid bugs such as the one reported by the issue reporter

@Baroshem
Copy link
Contributor

Baroshem commented Aug 5, 2022

Decided to close this PR as it does not solve the issue. I will work on it and develop a different fix instead.

@Baroshem Baroshem closed this Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error while getting products without assets
2 participants