Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Run Vsbridge Dataprovider before Custom Dataproviders #317

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

parlt
Copy link

@parlt parlt commented Jul 24, 2020

#316 Run Vsbridge Dataprovider before Custom Dataproviders

module-vsbridge-indexer-core/Indexer/GenericIndexerHandler.php line 165
without sorting, the custom data providers are called before the core data providers (f.e. if the vendor name starts with A or B)
but only with the core data providers the necessary attribute values are added
only if we have the attribute values, we can implement logic based on Attribute Indexes
there is no option to sort data providers by xml

@afirlejczyk
Copy link
Contributor

afirlejczyk commented Jul 24, 2020

Did you add module dependencies in your custom module?
e.g.

        <sequence>
            <module name="Divante_VsbridgeIndexerCatalog"/>
        </sequence>

Than your XML should be load later...

The proper solution would be to add support for sortOrder option in data providers.

@parlt
Copy link
Author

parlt commented Jul 24, 2020

Yes we have set a sequence in our module so there is a dependency between our module and the indexer module.

You can reproduce it. Create a Module with f.e. Vendor name B. add the Divante_VsbridgeIndexerCatalog as dependency Create a dataprovider f.e. with name b_dataprovider.
And Take a look in the getDataProvider and the array behind them. You Will see the the b_dataprovider is before the divante dataprovider

@afirlejczyk
Copy link
Contributor

OK. But still, I would go with the option to add sortOrder to data providers.

@parlt
Copy link
Author

parlt commented Jul 24, 2020

To add a sortOrder Option in the dataprovider xml/xsd snipped will be the best solution. How long dou you need to implement this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants