Skip to content

Commit

Permalink
feat: add node 18 support (#1449)
Browse files Browse the repository at this point in the history
Co-authored-by: John Doe <[email protected]>
  • Loading branch information
bartoszherba and mirouse authored Jul 24, 2023
1 parent f07040f commit ea2fb1b
Show file tree
Hide file tree
Showing 6 changed files with 44 additions and 41 deletions.
6 changes: 6 additions & 0 deletions .changeset/seven-emus-marry.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@vue-storefront/magento-api": minor
"@vue-storefront/magento-sdk": minor
---

add node 18 support
3 changes: 2 additions & 1 deletion .github/workflows/continuous-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ jobs:
secrets: inherit
with:
enterprise: false

node_version: '["16", "18"]'

sonarcloud-api-client:
name: 'SonarCloud API Client'
needs: [continous-integration]
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"@vue-storefront/eslint-config-integrations": "^0.0.14",
"@vue-storefront/integrations-tsconfig": "^0.0.2",
"@vue-storefront/jest-config": "^0.0.2",
"@vue-storefront/rollup-config": "^0.0.2",
"@vue-storefront/rollup-config": "^0.0.3",
"all-contributors-cli": "^6.20.0",
"esbuild": "^0.14.23",
"lerna": "^4.0.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/api-client/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,6 @@
"registry": "https://registry.npmjs.org"
},
"engines": {
"node": ">=16.x"
"node": ">=16.x < 19"
}
}
2 changes: 1 addition & 1 deletion packages/sdk/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,6 @@
"registry": "https://registry.npmjs.org"
},
"engines": {
"node": ">=16.x"
"node": ">=16.x < 19"
}
}
70 changes: 33 additions & 37 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2570,7 +2570,7 @@
estree-walker "^1.0.1"
picomatch "^2.2.2"

"@rollup/pluginutils@^4.1.0", "@rollup/pluginutils@^4.1.1":
"@rollup/pluginutils@^4.1.1", "@rollup/pluginutils@^4.1.2":
version "4.2.1"
resolved "https://registry.yarnpkg.com/@rollup/pluginutils/-/pluginutils-4.2.1.tgz#e6c6c3aba0744edce3fb2074922d3776c0af2a6d"
integrity sha512-iKnFXr7NkdZAIHiIWE+BX5ULi/ucVFYWD6TbAV+rZctiRTY2PL6tsIKhoIOaoskiWAkgu+VsbXgUVDNLHf+InQ==
Expand Down Expand Up @@ -2975,15 +2975,15 @@
helmet "^5.1.1"
rimraf "^4.1.2"

"@vue-storefront/rollup-config@^0.0.2":
version "0.0.2"
resolved "https://registry.yarnpkg.com/@vue-storefront/rollup-config/-/rollup-config-0.0.2.tgz#09f97a6c8ea9c9fa0a2c9c3c13a696f620cc3575"
integrity sha512-BfnGBZUeTWCwB1FUiNFjzIYUt6Db5G1vMzNFoSwua6ZfVI/hmVWjd/0Z2t0MHsXvl6yIdqVRBwP2mbckYtVxgQ==
"@vue-storefront/rollup-config@^0.0.3":
version "0.0.3"
resolved "https://registry.yarnpkg.com/@vue-storefront/rollup-config/-/rollup-config-0.0.3.tgz#e8481c66908b92675daefdac100319e08952e479"
integrity sha512-YsrKqyBu+6+lxS4EG3p+bw26obhu5+NQ+E98PTCLFXbepk29MBGqxc3394zCZAFAbmTnWzPLeAm75TrllhKGSw==
dependencies:
"@rollup/plugin-commonjs" "^21.0.1"
"@rollup/plugin-node-resolve" "^13.0.6"
rollup "^2.59.0"
rollup-plugin-typescript2 "^0.30.0"
rollup-plugin-typescript2 "^0.35.0"

"@vue-storefront/sdk@^1.0.0":
version "1.1.1"
Expand Down Expand Up @@ -5379,7 +5379,7 @@ [email protected]:
statuses "2.0.1"
unpipe "~1.0.0"

find-cache-dir@^3.3.1:
find-cache-dir@^3.3.2:
version "3.3.2"
resolved "https://registry.yarnpkg.com/find-cache-dir/-/find-cache-dir-3.3.2.tgz#b30c5b6eff0730731aea9bbd9dbecbd80256d64b"
integrity sha512-wXZV5emFEjrridIgED11OoUKLxiYjAcqot/NJdAkOhlJ+vGzwhOAfcG5OX1jP+S0PcjEn8bdMJv+g2jwQ3Onig==
Expand Down Expand Up @@ -5485,14 +5485,14 @@ [email protected]:
resolved "https://registry.yarnpkg.com/fresh/-/fresh-0.5.2.tgz#3d8cadd90d976569fa835ab1f8e4b23a105605a7"
integrity sha512-zJ2mQYM18rEFOudeV4GShTGIQ7RbzA7ozbU9I/XBpm7kqgMywgmylMwXHxZJmkVoYkna9d2pVXVXPdYTP9ej8Q==

fs-extra@8.1.0, fs-extra@^8.1.0:
version "8.1.0"
resolved "https://registry.yarnpkg.com/fs-extra/-/fs-extra-8.1.0.tgz#49d43c45a88cd9677668cb7be1b46efdb8d2e1c0"
integrity sha512-yhlQgA6mnOJUKOsRUFsgJdQCvkKhcz8tlZG5HBQfReYZy46OwLcY+Zia0mtdHsOo9y/hP+CxMN0TU9QxoOtG4g==
fs-extra@^10.0.0:
version "10.1.0"
resolved "https://registry.yarnpkg.com/fs-extra/-/fs-extra-10.1.0.tgz#02873cfbc4084dde127eaa5f9905eef2325d1abf"
integrity sha512-oRXApq54ETRj4eMiFzGnHWGy+zo5raudjuxN0b8H7s/RU2oW0Wvsx9O0ACRN/kRq9E8Vu/ReskGB5o3ji+FzHQ==
dependencies:
graceful-fs "^4.2.0"
jsonfile "^4.0.0"
universalify "^0.1.0"
jsonfile "^6.0.1"
universalify "^2.0.0"

fs-extra@^7.0.1:
version "7.0.1"
Expand All @@ -5503,6 +5503,15 @@ fs-extra@^7.0.1:
jsonfile "^4.0.0"
universalify "^0.1.0"

fs-extra@^8.1.0:
version "8.1.0"
resolved "https://registry.yarnpkg.com/fs-extra/-/fs-extra-8.1.0.tgz#49d43c45a88cd9677668cb7be1b46efdb8d2e1c0"
integrity sha512-yhlQgA6mnOJUKOsRUFsgJdQCvkKhcz8tlZG5HBQfReYZy46OwLcY+Zia0mtdHsOo9y/hP+CxMN0TU9QxoOtG4g==
dependencies:
graceful-fs "^4.2.0"
jsonfile "^4.0.0"
universalify "^0.1.0"

fs-extra@^9.1.0:
version "9.1.0"
resolved "https://registry.yarnpkg.com/fs-extra/-/fs-extra-9.1.0.tgz#5954460c764a8da2094ba3554bf839e6b9a7c86d"
Expand Down Expand Up @@ -6284,7 +6293,7 @@ is-ci@^3.0.1:
dependencies:
ci-info "^3.2.0"

is-core-module@^2.11.0, is-core-module@^2.2.0, is-core-module@^2.5.0:
is-core-module@^2.11.0, is-core-module@^2.5.0:
version "2.12.1"
resolved "https://registry.yarnpkg.com/is-core-module/-/is-core-module-2.12.1.tgz#0c0b6885b6f80011c71541ce15c8d66cf5a4f9fd"
integrity sha512-Q4ZuBAe2FUsKtyQJoQHlvP8OvBERxO3jEmy1I7hcRXcJBGGHFh/aJBswbXuS9sgrDH2QUO8ilkwNPHvHMd8clg==
Expand Down Expand Up @@ -8481,7 +8490,7 @@ path-key@^3.0.0, path-key@^3.1.0:
resolved "https://registry.yarnpkg.com/path-key/-/path-key-3.1.1.tgz#581f6ade658cbba65a0d3380de7753295054f375"
integrity sha512-ojmeN0qd+y0jszEtoY48r0Peq5dwMEkIlCOu6Q5f41lfkswXuKtYrhgoTpLnyIcHm24Uhqx+5Tqm2InSwLhE6Q==

path-parse@^1.0.6, path-parse@^1.0.7:
path-parse@^1.0.7:
version "1.0.7"
resolved "https://registry.yarnpkg.com/path-parse/-/path-parse-1.0.7.tgz#fbc114b60ca42b30d9daf5858e4bd68bbedb6735"
integrity sha512-LDJzPVEEEPR+y48z93A0Ed0yXb8pAByGWo/k5YYdYgpY2/2EsOsksJrq7lOHxryrVOn1ejG6oAp8ahvOIQD8sw==
Expand Down Expand Up @@ -9066,14 +9075,6 @@ resolve.exports@^2.0.0:
resolved "https://registry.yarnpkg.com/resolve.exports/-/resolve.exports-2.0.2.tgz#f8c934b8e6a13f539e38b7098e2e36134f01e800"
integrity sha512-X2UW6Nw3n/aMgDVy+0rSqgHlv39WZAlZrXCdnbyEiKm17DSqHX4MmQMaST3FbeWR5FTuRcUwYAziZajji0Y7mg==

[email protected]:
version "1.20.0"
resolved "https://registry.yarnpkg.com/resolve/-/resolve-1.20.0.tgz#629a013fb3f70755d6f0b7935cc1c2c5378b1975"
integrity sha512-wENBPt4ySzg4ybFQW2TT1zMQucPK95HSh/nq2CFTZVOGut2+pQvSsgtda4d26YrYcr067wjbmzOG8byDPBX63A==
dependencies:
is-core-module "^2.2.0"
path-parse "^1.0.6"

resolve@^1.10.0, resolve@^1.17.0, resolve@^1.19.0, resolve@^1.20.0, resolve@^1.22.1:
version "1.22.2"
resolved "https://registry.yarnpkg.com/resolve/-/resolve-1.22.2.tgz#0ed0943d4e301867955766c9f3e1ae6d01c6845f"
Expand Down Expand Up @@ -9139,16 +9140,16 @@ rimraf@^5.0.0:
dependencies:
glob "^10.2.5"

rollup-plugin-typescript2@^0.30.0:
version "0.30.0"
resolved "https://registry.yarnpkg.com/rollup-plugin-typescript2/-/rollup-plugin-typescript2-0.30.0.tgz#1cc99ac2309bf4b9d0a3ebdbc2002aecd56083d3"
integrity sha512-NUFszIQyhgDdhRS9ya/VEmsnpTe+GERDMmFo0Y+kf8ds51Xy57nPNGglJY+W6x1vcouA7Au7nsTgsLFj2I0PxQ==
rollup-plugin-typescript2@^0.35.0:
version "0.35.0"
resolved "https://registry.yarnpkg.com/rollup-plugin-typescript2/-/rollup-plugin-typescript2-0.35.0.tgz#a84fb4e802b919613f31552c69c3415101b547c1"
integrity sha512-szcIO9hPUx3PhQl91u4pfNAH2EKbtrXaES+m163xQVE5O1CC0ea6YZV/5woiDDW3CR9jF2CszPrKN+AFiND0bg==
dependencies:
"@rollup/pluginutils" "^4.1.0"
find-cache-dir "^3.3.1"
fs-extra "8.1.0"
resolve "1.20.0"
tslib "2.1.0"
"@rollup/pluginutils" "^4.1.2"
find-cache-dir "^3.3.2"
fs-extra "^10.0.0"
semver "^7.3.7"
tslib "^2.4.0"

rollup@^2.59.0:
version "2.79.1"
Expand Down Expand Up @@ -10001,11 +10002,6 @@ tsconfig-paths@^3.14.1:
minimist "^1.2.6"
strip-bom "^3.0.0"

[email protected]:
version "2.1.0"
resolved "https://registry.yarnpkg.com/tslib/-/tslib-2.1.0.tgz#da60860f1c2ecaa5703ab7d39bc05b6bf988b97a"
integrity sha512-hcVC3wYEziELGGmEEXue7D75zbwIIVUMWAVbHItGPx0ziyXxrOMQx4rQEVEV45Ut/1IotuEvwqPopzIOkDMf0A==

tslib@^1.8.1, tslib@^1.9.0:
version "1.14.1"
resolved "https://registry.yarnpkg.com/tslib/-/tslib-1.14.1.tgz#cf2d38bdc34a134bcaf1091c41f6619e2f672d00"
Expand Down

0 comments on commit ea2fb1b

Please sign in to comment.