Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add configurable/bundle products to cart #1512

Merged
merged 4 commits into from
Apr 4, 2024
Merged

feat: add configurable/bundle products to cart #1512

merged 4 commits into from
Apr 4, 2024

Conversation

bartoszherba
Copy link
Collaborator

@bartoszherba bartoszherba commented Apr 4, 2024 •
edited
Loading

closing https://alokai.atlassian.net/browse/ES-159

๐Ÿ”— Linked issue

โ“ Type of change

  • ๐Ÿ“– Documentation (updates to the documentation, readme or JSDoc annotations)
  • ๐Ÿž Bug fix (a non-breaking change that fixes an issue)
  • ๐Ÿ‘Œ Enhancement (improving an existing functionality like performance)
  • โœจ New feature (a non-breaking change that adds functionality)
  • ๐Ÿงน Chore (updates to the build process or auxiliary tools and libraries)
  • โš ๏ธ Breaking change (fix or feature that would cause existing functionality to change)

๐Ÿ“š Description

๐Ÿ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@bartoszherba bartoszherba requested a review from a team as a code owner April 4, 2024 08:33
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 4, 2024 •
edited
Loading

๐Ÿฆ‹ Changeset detected

Latest commit: e5255ad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@vue-storefront/magento-api Minor
@vue-storefront/magento-sdk Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

lsliwaradioluz
lsliwaradioluz previously approved these changes Apr 4, 2024
View reviewed changes
packages/sdk/src/methods/addBundleProductsToCart/index.ts Show resolved Hide resolved
packages/sdk/src/methods/addBundleProductsToCart/index.ts Outdated Show resolved Hide resolved
packages/sdk/src/methods/addBundleProductsToCart/index.ts Outdated Show resolved Hide resolved
packages/sdk/src/methods/addBundleProductsToCart/index.ts Outdated Show resolved Hide resolved
packages/sdk/src/methods/addBundleProductsToCart/index.ts Outdated Show resolved Hide resolved
packages/sdk/src/methods/addConfigurableProductsToCart/index.ts Show resolved Hide resolved
packages/sdk/src/methods/addConfigurableProductsToCart/index.ts Outdated Show resolved Hide resolved
packages/sdk/src/methods/addConfigurableProductsToCart/index.ts Outdated Show resolved Hide resolved
packages/sdk/src/methods/addConfigurableProductsToCart/index.ts Outdated Show resolved Hide resolved
@bartoszherba @lsliwaradioluz
Apply suggestions from code review
e5255ad 
Co-authored-by: ลukasz ลšliwa <[email protected]>
@bartoszherba bartoszherba merged commit eda02ee into main Apr 4, 2024
4 checks passed
@bartoszherba bartoszherba deleted the feat/missing-add-products-to-cart-methods branch April 4, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsliwaradioluz lsliwaradioluz lsliwaradioluz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartoszherba @lsliwaradioluz