Update to node 18 and swap Lerna for Turbo #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 37565df The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
sethidden
force-pushed
the
update-to-node-18
branch
from
d5787ee to
7f73e9b
Compare
Because of turbo, unit tests and integration tests can run in different order. Before adding turbo, the test script was like "yarn test:unit && yarn test:integration". If both tests generated coverage, in the coverage folder there'd factually be the integration test coverage. But now that they run out of order, we don't know what's in there. Here I reverted to a state where coverage from unit tests is only reported, as you normally collect coverage from unit tests.
sethidden
force-pushed
the
update-to-node-18
branch
from
7f73e9b to
37565df
Compare
Fifciu
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.