Some improvements I made #153
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esn't use capitalized and singular name for entities)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well this is originally for #147, that since Hasura released its v1.3.0 it had beta support for Relay-styled query, so using
ConnectionMode.EDGESalmost worked out of the box! The problem is I cannot seem to totally refactor to support logical queries (AND, OR, EQ, GT, etc.), but most other things I found that are problematic were fixed to a certain degree, and although the test suite almost passes (what is that last one skipped suite), the coverage is drastically reduced to 94%. I haven't made more tests to the new changes too but I think it is not quite necessary.