Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: search controls no longer wrap for an improved mobile experience. #4033

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

crhallberg
Copy link
Contributor

Fixes VUFIND-1679.

image

@crhallberg crhallberg added this to the 10.1 milestone Oct 22, 2024
@crhallberg crhallberg self-assigned this Oct 22, 2024
@crhallberg crhallberg requested a review from sturkel89 October 22, 2024 16:27
Copy link
Member

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @crhallberg! This looks reasonable to me from a code review perspective, but I'll wait for @sturkel89's approval before merging.

Copy link
Contributor

@sturkel89 sturkel89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that "Results per page" no longer wraps at narrow widths and in my mobile emulator!

This is true in all five themes and in every language I tested.

Here's one example:

image

I think this PR is ready to merge.


There's one remaining issue in the JIRA ticket, though: the "Results per page" and "Sort" labels and boxes look great in relation to one another in full screen in English, but when the interface language is changed they are resized independently and sometimes look pretty wonky:

image

image

image

image

When time allows, can we create a new PR that addresses this issue?

@demiankatz
Copy link
Member

Thanks, @sturkel89, I'll merge this as incremental progress but leave the JIRA ticket open until we have time to discuss the second piece of the puzzle.

@demiankatz demiankatz merged commit 8028edc into vufind-org:dev Oct 23, 2024
6 checks passed
@demiankatz demiankatz deleted the fix-jira-1679 branch October 23, 2024 20:51
@sturkel89
Copy link
Contributor

The other issue has been fixed too! #4041

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants