configd: T6608: report uncaught config script exceptions as commit error

vyos · Jul 30, 2024 · be47832 · be47832
1 parent 80c45be
commit be47832
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/services/vyos-configd b/src/services/vyos-configd
@@ -147,8 +147,10 @@ def run_script(script_name, config, args) -> int:
         explicit_print(session_out, session_mode, str(e))
         return R_ERROR_COMMIT
     except Exception as e:
-        logger.critical(e)
-        return R_ERROR_DAEMON
+        s = f'{type(e).__name__}: {str(e)}'
+        logger.error(s)
+        explicit_print(session_out, session_mode, s)
+        return R_ERROR_COMMIT
 
     return R_SUCCESS