Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system_option: T5552: Apply IPv4 and IPv6 options after reapplying sysctls by TuneD #3853

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

natali-rs1985
Copy link
Contributor

@natali-rs1985 natali-rs1985 commented Jul 23, 2024

Change Summary

Since TuneD reapplies sysctls from configuration files (particularly net.ipv6.conf.all.forwarding) we need to apply sysctl parameters that were manually set for IPv4 and IPv6

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

system_option

Proposed changes

How to test

set system ip disable-forwarding
set system ipv6 disable-forwarding
commit

vyos@vyos# sudo sysctl -a | grep conf.all.forwarding
net.ipv4.conf.all.forwarding = 0
net.ipv6.conf.all.forwarding = 0

set system option performance throughput
commit

Before the fix after this commit ipv4 and ipv6 forwarding was enabled. Now it stays as it should be.

vyos@vyos# sudo sysctl -a | grep conf.all.forwarding
net.ipv4.conf.all.forwarding = 0
net.ipv6.conf.all.forwarding = 0

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Jul 23, 2024

👍
No issues in PR Title / Commit Title

Copy link

👍
No issues in unused-imports

Copy link

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests ❌ failed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed

@c-po
Copy link
Member

c-po commented Jul 23, 2024

@Mergifyio backport sagitta circinus

Copy link
Contributor

mergify bot commented Jul 23, 2024

backport sagitta circinus

✅ Backports have been created

@c-po c-po enabled auto-merge July 23, 2024 17:16
@c-po c-po merged commit 04b7006 into vyos:current Jul 24, 2024
16 of 17 checks passed
c-po added a commit that referenced this pull request Jul 28, 2024
system_option: T5552: Apply IPv4 and IPv6 options after reapplying sysctls by TuneD (backport #3853)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants