Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op_mode: T6596: pppoe operation command failed #3860

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

natali-rs1985
Copy link
Contributor

@natali-rs1985 natali-rs1985 commented Jul 24, 2024

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

op mode

Proposed changes

How to test

connect interface pppoe1

disconnect interface pppoe1

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Jul 24, 2024

👍
No issues in PR Title / Commit Title

Copy link

👍
No issues in unused-imports

@c-po
Copy link
Member

c-po commented Jul 24, 2024

@Mergifyio backport sagitta circinus

Copy link
Contributor

mergify bot commented Jul 24, 2024

backport sagitta circinus

✅ Backports have been created

@c-po c-po enabled auto-merge July 24, 2024 08:34
@c-po c-po merged commit 23238b8 into vyos:current Jul 24, 2024
13 of 14 checks passed
c-po added a commit that referenced this pull request Jul 24, 2024
op_mode: T6596: pppoe operation command failed (backport #3860)
@c-po
Copy link
Member

c-po commented Jul 24, 2024

Sagitta backport not needed - see closure comment

Copy link

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests ❌ failed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants