Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pki: T6809: Support system install of CA certificates #4204

Open
wants to merge 2 commits into
base: current
Choose a base branch
from

Conversation

sarthurdev
Copy link
Member

Change Summary

Adds system-install node to CAs which will install it into the router's CA bundle

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

pki

Proposed changes

  • Add CLI node system-install for PKI CA certificates
  • Cleans up any stale certificates on boot and commit
  • Installs selected CAs to /usr/local/share/ca-certificates/vyos and triggers update-ca-certificates
  • Includes code clean-up for the node_changed portion of PKI conf script

How to test

Installing:

vyos@vyos# set pki ca test system-install
[edit]
vyos@vyos# commit
[edit]
vyos@vyos# openssl crl2pkcs7 -nocrl -certfile /etc/ssl/certs/ca-certificates.crt | openssl pkcs7 -print_certs -noout | grep 'vyos'
subject=C = GB, ST = Some-State, L = Some-City, O = VyOS, CN = vyos.io
issuer=C = GB, ST = Some-State, L = Some-City, O = VyOS, CN = vyos.io
[edit]
vyos@vyos#

Cleanup:

vyos@vyos# del pki
[edit]
vyos@vyos# commit
[edit]
vyos@vyos# openssl crl2pkcs7 -nocrl -certfile /etc/ssl/certs/ca-certificates.crt | openssl pkcs7 -print_certs -noout | grep 'vyos'
[edit]
vyos@vyos#

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Nov 22, 2024

👍
No issues in PR Title / Commit Title

Copy link

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests (no interfaces) ❌ failed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

@sarthurdev sarthurdev changed the title pki: T6809: Support system install of CA certificates pki: T6809: Support system install of CA certificates Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant