Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6906: IPoE-server add start-session option #4206

Open
wants to merge 1 commit into
base: current
Choose a base branch
from

Conversation

sever-sever
Copy link
Member

Change Summary

Add the abbility to start IPoE session by unclassified-packet. It allows the cases when subscriber configures the address manually (static) and accel-ppp can start session on any packet. By default start session on DHCPv4 Discover packet.

set service ipoe-server interface eth1 start-session < auto | dhcpv4 | unclassified-packet>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

ipoe-server

Proposed changes

How to test

Configure start-session on unclassified-packet

set service ipoe-server authentication mode 'radius'
set service ipoe-server authentication radius server 127.0.0.1 key 'vyos-secret'
set service ipoe-server client-ip-pool POOL range '100.64.0.0/22'
set service ipoe-server gateway-address '100.64.0.1/22'
set service ipoe-server interface eth1 mode 'l2'
set service ipoe-server interface eth1 network 'shared'
set service ipoe-server interface eth1 start-session 'unclassified-packet'
set service ipoe-server name-server '1.1.1.1'
set service ipoe-server name-server '8.8.8.8'

Check config, expecting start=up:

vyos@r14# cat /run/accel-pppd/ipoe.conf | grep interface
interface=eth1,shared=1,mode=L2,ifcfg=1,start=up,ipv6=1
[edit]
vyos@r14# 

Configuration on the client site:

set interfaces ethernet eth1 address '100.64.0.10/22'

Check sessions:

vyos@r14:~$ show ipoe-server sessions 
ifname |  username   |    calling-sid    |     ip      | ip6 | ip6-dp | rate-limit | type | comp | state  |  uptime  
--------+-------------+-------------------+-------------+-----+--------+------------+------+------+--------+----------
 ipoe0  | 100.64.0.10 | 52:54:00:09:0b:01 | 100.64.0.10 |     |        |            | ipoe |      | active | 00:16:15
vyos@r14:~$ 

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Add the abbility to start IPoE session by unclassified-packet.
It allows the cases when subscriber configures the address manually
(static) and accel-ppp can start session on any packet.
By default start session on DHCPv4 Discover packet.

set service ipoe-server interface eth1 start-session unclassified-packet
Copy link

👍
No issues in PR Title / Commit Title

Copy link

CI integration 👍 passed!

Details

CI logs

  • CLI Smoketests (no interfaces) 👍 passed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant