Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smoketest: T6746: add substring search in getFRRconfig() #4256

Closed
wants to merge 1 commit into from

Conversation

c-po
Copy link
Member

@c-po c-po commented Dec 25, 2024

Change Summary

Some daemons (e.g. bgpd) have several nested substrings/sections like

router bgp 100
  address-family ipv4 unicast
  ..
  exit-address-family
exit

We can now use getFRRconfig() with the substring option to extract only

 address-family ipv4 unicast
 ..
 exit-address-family

Making config validation more granular

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Smoketest infrastructure

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Dec 25, 2024

👍
No issues in PR Title / Commit Title

Some daemons (e.g. bgpd) have several nested substrings/sections like

router bgp 100
 address-family ipv4 unicast
 ..
 exit-address-family
exit

We can now use getFRRconfig() with the substring option to extract only
 address-family ipv4 unicast
 ..
 exit-address-family

Making config validation more granular
@c-po c-po force-pushed the smoketest-fixes branch 2 times, most recently from 4e51d79 to c6100df Compare December 26, 2024 16:09
@c-po c-po closed this Dec 26, 2024
@c-po c-po deleted the smoketest-fixes branch December 26, 2024 16:25
Copy link

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests (no interfaces) ❌ failed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant