Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added method to create otc contract #46

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

Added method to create otc contract #46

wants to merge 7 commits into from

Conversation

iamakshat01
Copy link
Contributor

Copy link

@giacomo-cc giacomo-cc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tried now and everything seems working fine:
Screenshot 2023-01-18 at 16 11 06

following some consideration:

default values
I would add some default values to the options, we could use the following:

  • collateral mint: usdc for mainnet and vyper devUSD (7XSvJnS19TodrQJSbjUR6tEGwmYyL1i9FX7Z5ZQHc53W) for devnet
  • default oracle for both switchboard and pyth
  • default dates (the most important one): deposit start could be 1h before now(), deposit end 5min after now() and settle start 15min after now()

progress during tx sending
we should provide some feedback to the users for better UX after the tx submit. as of now the screen is stuck for a couple of seconds (ofc depends on the rpc performance, but with public rpcs the magnitude is in terms of 10/20 seconds) and then the ouput with the contract pubkey and the tx sig. We could provide an indeterminate progress bar is there something ready out of the box or simply a console.log with "tx sending" -> "tx confirming" -> "done"

let me know your feedbacks

@giacomo-cc giacomo-cc marked this pull request as ready for review January 18, 2023 15:18
@giacomo-cc giacomo-cc removed their request for review July 15, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create an OTC contract
2 participants