Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vk: do not draw into empty swapchain #560

Merged
merged 1 commit into from
Sep 12, 2023
Merged

vk: do not draw into empty swapchain #560

merged 1 commit into from
Sep 12, 2023

Conversation

w23
Copy link
Owner

@w23 w23 commented Sep 12, 2023

On Windows we're seeing a max size = 0x0 swapchains. Those cannot be created or used. Make sure that we're not, and we're not trying to draw anything when there's no swapchain available.

Unfortunately we still have to call some rendering functions (without actually rendering anything) to make sure that various invariants hold.

fixes #463

On Windows we're seeing a max size = 0x0 swapchains. Those cannot be created or used. Make sure that we're not, and we're not trying to draw anything when there's no swapchain available.

Unfortunately we still have to call some rendering functions (without actually rendering anything) to make sure that various invariants hold.

fixes #463
@0x4E69676874466F78
Copy link
Collaborator

Всё хорошо можно мержить.

@w23 w23 merged commit 64e1a9b into vulkan Sep 12, 2023
8 checks passed
@w23 w23 deleted the E294-zero-swapchain-463 branch September 12, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Crash when minimizing a window
2 participants